Skip to content

Comments

chore : 모니터링을 위한 actuator 엔드포인트 개방 / #118#119

Merged
JayongLee merged 3 commits intomainfrom
ci/#118
Dec 6, 2025
Merged

chore : 모니터링을 위한 actuator 엔드포인트 개방 / #118#119
JayongLee merged 3 commits intomainfrom
ci/#118

Conversation

@JayongLee
Copy link
Member

@JayongLee JayongLee commented Dec 6, 2025

🗞️ 연관된 이슈

🔥 이슈번호

✅ 작업 내용

  • 모니터링을 위한 actuator 엔드포인트 개방

📸 스크린샷 (선택)

체크리스트 ✅

  • 코드가 정상적으로 컴파일되나요?
  • merge할 브랜치의 위치를 확인했나요?
  • 테스트 코드를 작성하셨나요?

기타

@JayongLee JayongLee self-assigned this Dec 6, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 6, 2025

Summary of Changes

Hello @JayongLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 애플리케이션 모니터링을 강화하기 위해 Spring Boot Actuator를 통해 Prometheus 메트릭 엔드포인트를 개방하는 변경사항을 포함합니다. 이를 통해 'core-banking' 애플리케이션의 성능 및 상태에 대한 가시성을 확보하고, 운영 환경에서 시스템의 건강 상태를 효과적으로 추적할 수 있게 됩니다.

Highlights

  • Prometheus 레지스트리 추가: build.gradle 파일에 'micrometer-registry-prometheus' 의존성을 추가하여 Prometheus를 통한 메트릭 수집을 가능하게 했습니다.
  • Actuator 엔드포인트 개방: application.yml 파일에서 '/actuator/metrics' 및 '/actuator/prometheus' 엔드포인트에 대한 읽기 접근 권한을 부여하고 웹 노출 목록에 추가했습니다.
  • 메트릭 태그 추가: 모든 메트릭에 'application: core-banking' 태그를 추가하여 메트릭 식별 및 필터링을 용이하게 했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 6, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

모니터링을 위해 프로메테우스 의존성을 추가하고 액추에이터 엔드포인트를 개방하는 변경사항입니다. 전반적으로 올바른 방향이지만, 보안을 위해 /actuator/metrics 엔드포인트 노출은 재고가 필요해 보입니다. 이 엔드포인트는 상세한 내부 정보를 노출할 수 있어, 특별한 경우가 아니라면 /actuator/prometheus만 노출하는 것이 안전합니다. 자세한 내용은 코드 리뷰 코멘트를 참고해주세요.

@JayongLee JayongLee merged commit 6579a38 into main Dec 6, 2025
1 check passed
@JayongLee JayongLee deleted the ci/#118 branch December 6, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JayongLee JayongLee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JayongLee